Wireshark-commits: [Wireshark-commits] master 787d61c: tshark: free exp_pdu_filename and capture_op
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 17 Aug 2018 22:21:00 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=787d61c0a4bac5136d54027aa71f249e6384b307
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

787d61c by Vasil Velichkov (vvvelichkov@xxxxxxxxx):

    tshark: free exp_pdu_filename and capture_opts->save_file
    
    valgrind --tool=memcheck --leak-check=full ./run/tshark -r sctp.pcap -U "OSI layer 3" -w exported.pcap
    
    13 bytes in 1 blocks are definitely lost in loss record 20 of 93
       at 0x4C2EBAB: malloc (vg_replace_malloc.c:299)
       by 0xB27B3C5: g_malloc (gmem.c:99)
       by 0xB294D22: g_strdup (gstrfuncs.c:363)
       by 0x117B5D: capture_opts_add_opt (capture_opts.c:889)
       by 0x118C0E: main (tshark.c:1112)
    
    Change-Id: I9b794015aa4d2626b43a5743864c2d732c6acaa1
    Reviewed-on: https://code.wireshark.org/review/29125
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  b1b9805   GTPv2: Document parsing of 8.107 Node Identifier
     add  787d61c   tshark: free exp_pdu_filename and capture_opts->save_file


Summary of changes:
 capture_opts.c | 1 +
 tshark.c       | 7 +++++--
 2 files changed, 6 insertions(+), 2 deletions(-)