Wireshark-commits: [Wireshark-commits] master-2.6 65395cc: TLS13: properly skip over failed decrypt
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 17 Aug 2018 09:39:32 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=65395cc80db8b97392c6bc6a3d1a425e6a8d5c48
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

65395cc by Peter Wu (peter@xxxxxxxxxxxxx):

    TLS13: properly skip over failed decryption of early data
    
    When early data is present but undecryptable (due to lack of keys), it
    should not result in incrementing the sequence number or the following
    application data from the client will fail to decrypt.
    
    Change-Id: I8016a30508d96c14cbd6a3b9c4af1591a6c437c3
    Ping-Bug: 12779
    Reviewed-on: https://code.wireshark.org/review/29169
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit fd7ec355ec4bf1f7c8129ff01135bb1387959a7e)
    Reviewed-on: https://code.wireshark.org/review/29172
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  81504de   Do not pass pipe handle to WaitForMultipleObjects
     add  65395cc   TLS13: properly skip over failed decryption of early data


Summary of changes:
 epan/dissectors/packet-ssl-utils.c | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)