Wireshark · Wireshark-commits: [Wireshark-commits] master-2.6 81504de: Do not pass pipe handle to WaitForMultipleObjects

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=81504de50f456aad920936875aa282c51af2eacb
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

81504de by Tomasz Moń (desowin@xxxxxxxxx):

    Do not pass pipe handle to WaitForMultipleObjects
    
    The Remarks section in WaitForMultipleObjects describes what kind of
    handles the function can wait for. Pipe handles are not listed there.
    
    The problem was introduced in c18459e66e8e71a8765bb9b8e2b3d2ba61855a3f
    
    While it might be possible to setup overlapped reads on the pipe handles
    and then wait on overlapped events, it would result in quite complex
    code. As a tradeoff, simply keep peeking at the pipes every 100 ms.
    
    Change-Id: I6ba4f4bf4c1d2af856027cca36ffd6d4f7f49f36
    Bug: 14657
    Reviewed-on: https://code.wireshark.org/review/29163
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    (cherry picked from commit 9ecc7906ef6a7c32217a2a8780d5374b0b5398de)
    Reviewed-on: https://code.wireshark.org/review/29167
    

Actions performed:

    from  6c4545c   Fix extcap initialization deadlock
     add  81504de   Do not pass pipe handle to WaitForMultipleObjects


Summary of changes:
 wsutil/ws_pipe.c | 60 ++++++++++++++++++++++++--------------------------------
 1 file changed, 26 insertions(+), 34 deletions(-)