Wireshark-commits: [Wireshark-commits] master 0001152: NBAP: Support IB_SG_DATA Encoding Variant 2
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 16 Aug 2018 19:31:17 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=00011526161779a6102c9feca4b4bc83d4829b33
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

0001152 by Darien Spencer (cusneud@xxxxxxxx):

    NBAP: Support IB_SG_DATA Encoding Variant 2
    
    The code was decoding IB_SG_DATA according to Encoding Variant 1.
    Added parsing of the second variant and a preference to let the user choose
    between the two.
    
    Bug: 15054
    Change-Id: I45efcb84c48d599b46037488792dbc5dad97ebd1
    Reviewed-on: https://code.wireshark.org/review/29018
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a322cf7   AT: Reorder commands dictionary
     add  0001152   NBAP: Support IB_SG_DATA Encoding Variant 2


Summary of changes:
 epan/dissectors/asn1/nbap/nbap.cnf               |  50 +++++-
 epan/dissectors/asn1/nbap/packet-nbap-template.c |  21 ++-
 epan/dissectors/packet-nbap.c                    | 191 +++++++++++++++--------
 3 files changed, 186 insertions(+), 76 deletions(-)