Wireshark-commits: [Wireshark-commits] master ca75c14: HTTP: create dissector table for HTTP Upgrad
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 13 Aug 2018 08:20:41 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ca75c14f05777f2aa35f3c69aa547822bcc6081b
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ca75c14 by Peter Wu (peter@xxxxxxxxxxxxx):

    HTTP: create dissector table for HTTP Upgrade
    
    Based on an idea from David M. Lloyd, let subdissectors register
    themselves with the HTTP dissector based on the Upgrade header instead
    of the other way round.
    
    Tested with SSTP (bug 82390), WebSocket (bug 13889), HTTP2 PRI without
    Upgrade (bug 11331), h2c (from HTTP2 wiki), spdy/3.1 (bug 12874).
    
    Change-Id: I1425b7119d4d85e626032408504fc2c6b2f2eeb8
    Reviewed-on: https://code.wireshark.org/review/29112
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3a9f171   HTTP: start dissecting upgraded connections right after upgrade
     add  ca75c14   HTTP: create dissector table for HTTP Upgrade


Summary of changes:
 epan/dissectors/packet-http.c      | 73 ++++++++++++++++----------------------
 epan/dissectors/packet-http.h      |  2 +-
 epan/dissectors/packet-http2.c     |  5 +--
 epan/dissectors/packet-spdy.c      |  1 +
 epan/dissectors/packet-websocket.c |  5 ++-
 5 files changed, 40 insertions(+), 46 deletions(-)