Wireshark-commits: [Wireshark-commits] master 149e74b: Put the interface descrptions into the IDB w
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 13 Aug 2018 04:37:07 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=149e74b70d207228802a463214271c9e537476c9
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

149e74b by Guy Harris (guy@xxxxxxxxxxxx):

    Put the interface descrptions into the IDB when capturing to pcapng.
    
    capture_opts_add_iface_opt(), when called in a program acting as a
    capture child, will fetch the description for the interface, and will
    also generate a "display name" for the interface.
    
    In the process, we clean up capture_opts_add_iface_opt() a bit,
    combining duplicate code.
    
    We rename console_display_name to just display_name, as it may also be
    used in the title bar of Wireshark when capturing.
    
    Change-Id: Ifd18955bb3cb41df4c0ed4362d4854068c825b96
    Reviewed-on: https://code.wireshark.org/review/29117
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  d482627   Move get_iface_display_name() to ui/iface_lists.c.
     add  149e74b   Put the interface descrptions into the IDB when capturing to pcapng.


Summary of changes:
 capture_opts.c               | 276 ++++++++++++++++++++++++++-----------------
 capture_opts.h               |   6 +-
 caputils/capture-pcap-util.c | 153 ++++++++++++++++++++++--
 caputils/capture_ifinfo.h    |  11 ++
 dumpcap.c                    |  64 +++++++---
 ui/capture_ui_utils.c        |  22 ++--
 6 files changed, 387 insertions(+), 145 deletions(-)