Wireshark-commits: [Wireshark-commits] master-2.4 0233ea9: Clean up temporary filename generation.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 12 Aug 2018 03:44:19 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0233ea92612eb71ca8033290b01af338d95e113a
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

0233ea9 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up temporary filename generation.
    
    Don't put identical code in both arms of a conditional - move it out of
    the conditional.
    
    Doing that with one line of code means that the conditional is now
    *itself* duplicated in both arms of a conditional, so move it out, too.
    
    Change-Id: I07c1d00e7d0053684aa2ef74b460eb008b145015
    Reviewed-on: https://code.wireshark.org/review/29093
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit f033cd542efbfa857622853d5b3e53c712cf8344)
    Reviewed-on: https://code.wireshark.org/review/29095
    

Actions performed:

    from  cfb4f50   More interface view cleanups.
     add  0233ea9   Clean up temporary filename generation.


Summary of changes:
 dumpcap.c | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)