Wireshark-commits: [Wireshark-commits] master 991f5a6: More interface view cleanups.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 12 Aug 2018 01:56:29 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=991f5a6e858ea116cb938c9acacee415ee075bab
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

991f5a6 by Guy Harris (guy@xxxxxxxxxxxx):

    More interface view cleanups.
    
    Rename some of the columns - IFTREE_COL_NAME is the interface name,
    IFTREE_COL_DESCRIPTION is the description/friendly name, and a new
    IFTREE_COL_DISPLAY_NAME column is the display name (which may include
    both the description and the interface name).  Rename
    IFTREE_COL_INTERFACE_COMMENT to just IFTREE_COL_COMMENT - there's no
    *other* type of comment, and "IF" is short for "interface".
    
    In the interface frame, use IFTREE_COL_DISPLAY_NAME, as that's the only
    column that shows both and thus has something for all interfaces.
    
    In the "Manage interfaces" dialog, put the description before the
    interface name, as it was in earlier versions.
    
    Change-Id: If0d959dcd4ca99913c941df00621da3c478233f6
    Reviewed-on: https://code.wireshark.org/review/29090
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  713651d   Show just the description in the description column.
     add  991f5a6   More interface view cleanups.


Summary of changes:
 ui/qt/interface_frame.cpp                   |  8 ++++----
 ui/qt/manage_interfaces_dialog.cpp          |  6 +++---
 ui/qt/models/interface_tree_cache_model.cpp |  6 +++---
 ui/qt/models/interface_tree_model.cpp       | 20 ++++++++++++++------
 ui/qt/models/interface_tree_model.h         |  5 +++--
 5 files changed, 27 insertions(+), 18 deletions(-)