Wireshark-commits: [Wireshark-commits] master f543d4a: "It's not a valid text line" means "it's not
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 09 Aug 2018 10:05:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f543d4a2fdbdacfdd2308c27b904f3cbecba6e67
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f543d4a by Guy Harris (guy@xxxxxxxxxxxx):

    "It's not a valid text line" means "it's not an RFC 7468 file", not "it's bad".
    
    Don't return an error unless we get a read error.  If the line could be
    read, but isn't a valid text line, that just means it's not an RFC 7468
    text file.
    
    Change-Id: I04f48294cac213cf61b8dcb851b99dc6dd776df8
    Reviewed-on: https://code.wireshark.org/review/29039
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  1ac6908   GTPv2: update geographic_location_type_vals array
     add  f543d4a   "It's not a valid text line" means "it's not an RFC 7468 file", not "it's bad".


Summary of changes:
 wiretap/rfc7468.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)