Wireshark-commits: [Wireshark-commits] master b2d7da5: gsup: Don't print IEI + Length twice for unk
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 09 Aug 2018 07:01:32 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b2d7da58a4faf6d2eaa1c2617989269f3f1e98b7
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

b2d7da5 by Harald Welte (laforge@xxxxxxxxxxxx):

    gsup: Don't print IEI + Length twice for unknown IEs
    
    The handling for unknown IEs was flawed in that it printed
    the IEI and the IE Length lines twice: Once the general code before
    the switch statement, and then a second time inside the default
    case handling.
    
    Change-Id: Ic845bfb79e9ff881b39f709e3bff407e352c49fd
    Reviewed-on: https://code.wireshark.org/review/29005
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  297a6fe   gsup: Fix dissecting wildcard APN names
     add  b2d7da5   gsup: Don't print IEI + Length twice for unknown IEs


Summary of changes:
 epan/dissectors/packet-gsm_gsup.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)