Wireshark · Wireshark-commits: [Wireshark-commits] master ac27dc1: sctp: Improve exporting PDUs

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ac27dc1f5c9438eacf0cb79722610e332a815b64
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ac27dc1 by Vasil Velichkov (vvvelichkov@xxxxxxxxx):

    sctp: Improve exporting PDUs
    
    Export the PDUs in the following cases:
    
    - When sctp.ulp_dissection is FALSE
      Not having to dissect the upper layers greatly improve exporting speed.
      Previously no PDUs were exported becuase without dissection the upper
      layer name was not available. Now in this case the exported_pdu.tag is
      set to sctp.ppi or sctp.port table and the corresponding ppi or port
      is also set in the exported_pdu.this_table_val.
    - When the upper layer can't be dissected but at least one of the
      payload_proto_id, destport or srcport is not 0
    
    Refactor and move the common parts in a dedicated functions.
    
    Change-Id: Ie5073a5c7603e11c4a5703118fd81ac25bd924e9
    Reviewed-on: https://code.wireshark.org/review/28933
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  82454b8   print.c: Print FT_CHAR fields as FT_UINT8
     add  ac27dc1   sctp: Improve exporting PDUs


Summary of changes:
 epan/dissectors/packet-sctp.c | 105 +++++++++++++++++++++++++++---------------
 1 file changed, 69 insertions(+), 36 deletions(-)