Wireshark-commits: [Wireshark-commits] master 5129919: tap_export_pdu: Fix two memory leaks
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 03 Aug 2018 09:27:14 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=51299192e214d025d5d759bce776104a0f2a6ffc
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5129919 by Vasil Velichkov (vvvelichkov@xxxxxxxxx):

    tap_export_pdu: Fix two memory leaks
    
    253 (8 direct, 245 indirect) bytes in 1 blocks are definitely lost in loss record 87 of 93
       at 0x4C2EBAB: malloc (vg_replace_malloc.c:299)
       by 0xBC4B3C5: g_malloc (gmem.c:99)
       by 0x13E225: exp_pdu_open (tap_export_pdu.c:128)
    
    372 (40 direct, 332 indirect) bytes in 1 blocks are definitely lost in loss record 88 of 93
       at 0x4C2EBAB: malloc (vg_replace_malloc.c:299)
       by 0xBC4B3C5: g_malloc (gmem.c:99)
       by 0xBC62FF6: g_slice_alloc (gslice.c:1025)
       by 0xBC16984: g_array_sized_new (garray.c:194)
       by 0x13E143: exp_pdu_open (tap_export_pdu.c:93)
    
    Change-Id: I24a3cec1dc4491032232c282b01fea04a23872b3
    Reviewed-on: https://code.wireshark.org/review/28934
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  71759a7   PTP: fix typo path_delay -> peer_delay
     add  5129919   tap_export_pdu: Fix two memory leaks


Summary of changes:
 ui/tap_export_pdu.c | 18 ++++++++++--------
 ui/tap_export_pdu.h |  2 ++
 2 files changed, 12 insertions(+), 8 deletions(-)