Wireshark-commits: [Wireshark-commits] master-2.6 d994321: Revert "Have find_or_create_conversation
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 01 Aug 2018 02:57:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d994321c91d4950a112eae4e31871ead42e108a5
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

d994321 by Guy Harris (guy@xxxxxxxxxxxx):

    Revert "Have find_or_create_conversation() use pinfo->conv_endpoint if present."
    
    This reverts commit 420938f905b93c8fdc9e8a4f30a79c35348d7927.
    
    Creating endpoints, and corresponding conversations, for protocols atop which TCP or UDP runs can potentially cause attempts to look up the conversation to find the conversation for that protocol rather than for TCP/UDP, which can confuse protocols running atop TCP or UDP.
    
    Change-Id: I096d2de9727d52b05f1cb39325681665b496ccd0
    Reviewed-on: https://code.wireshark.org/review/28913
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  aff9243   Get rid of a no-longer-used dissector handle.
    adds  d994321   Revert "Have find_or_create_conversation() use pinfo->conv_endpoint if present."


Summary of changes:
 debian/libwireshark11.symbols |  2 +-
 epan/conversation.c           | 46 +++++++++++++++++++++----------------------
 epan/conversation.h           |  9 ++++++---
 epan/dissectors/packet-isdn.c |  5 ++---
 4 files changed, 32 insertions(+), 30 deletions(-)