Wireshark-commits: [Wireshark-commits] master-2.6 420938f: Have find_or_create_conversation() use p
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 31 Jul 2018 22:54:58 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=420938f905b93c8fdc9e8a4f30a79c35348d7927
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

420938f by Guy Harris (guy@xxxxxxxxxxxx):

    Have find_or_create_conversation() use pinfo->conv_endpoint if present.
    
    Add conversation_new_pinfo(), which uses the endpoint if present, and
    have find_or_create_conversation() use it rather than
    conversation_new().
    
    Remove find_or_create_conversation_by_id() - it's no longer needed.
    
    Bug: 15018
    Change-Id: Ib13e539751af0f071aede4ee0ed751d0cb72ba3f
    Reviewed-on: https://code.wireshark.org/review/28908
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit ba202ef36225b59eb797c5a48b8d4a4665b479c7)
    Reviewed-on: https://code.wireshark.org/review/28909
    

Actions performed:

    from  c39ce68   Export some more conversation functions.
    adds  420938f   Have find_or_create_conversation() use pinfo->conv_endpoint if present.


Summary of changes:
 debian/libwireshark11.symbols |  2 +-
 epan/conversation.c           | 46 +++++++++++++++++++++----------------------
 epan/conversation.h           |  9 +++------
 epan/dissectors/packet-isdn.c |  5 +++--
 4 files changed, 30 insertions(+), 32 deletions(-)