Wireshark-commits: [Wireshark-commits] master 205a4ac: No need to initialize cursorname_len.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 31 Jul 2018 06:48:54 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=205a4ac1443d7f328768f80bbacbd7eb6beef93f
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

205a4ac by Guy Harris (guy@xxxxxxxxxxxx):

    No need to initialize cursorname_len.
    
    Not initializing it also means that we'll get an error from compilers
    with sufficiently good dataflow analysis if we use it in, or before, the
    call itself, which is a Good Thing as we *shouldn't* use it before we
    know it.
    
    Change-Id: I99aa3fedd2a04f5bb6e60e0f6f8b0a3682263351
    Reviewed-on: https://code.wireshark.org/review/28888
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  8f56eb5   TDS: Fix bad proto_tree_add_item_ret_string_and_length call.
    adds  205a4ac   No need to initialize cursorname_len.


Summary of changes:
 epan/dissectors/packet-tds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)