Wireshark-commits: [Wireshark-commits] master 5fb611b: tds: fix uninitialized var.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 31 Jul 2018 04:35:37 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5fb611b5623638796f5ef8fed25846b40c8bbd1c
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5fb611b by Dario Lombardo (lomato@xxxxxxxxx):

    tds: fix uninitialized var.
    
    ../epan/dissectors/packet-tds.c:2659:27: error: variable 'cursorname_len' is uninitialized when used here [-Werror,-Wuninitialized]
                tvb, cur + 1, cursorname_len, tds_get_char_encoding(tds_info)|ENC_NA,
                              ^~~~~~~~~~~~~~
    ../epan/dissectors/packet-tds.c:2653:29: note: initialize the variable 'cursorname_len' to silence this warning
            guint cursorname_len;
                                ^
                                 = 0
    1 error generated.
    
    Change-Id: I21a1e34997af95097d3a916589f69b86a6fe0418
    Reviewed-on: https://code.wireshark.org/review/28883
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ead3d6b   Relax ERF heuristic
    adds  5fb611b   tds: fix uninitialized var.


Summary of changes:
 epan/dissectors/packet-tds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)