Wireshark-commits: [Wireshark-commits] master 7e755f7: SCTPGraphDialog: fix displaying a single TSN
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 30 Jul 2018 12:19:58 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7e755f71ad605e7b403d5fd52ef247042715ff7f
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7e755f7 by Vasil Velichkov (vasko@192.168.1.12):

    SCTPGraphDialog: fix displaying a single TSN
    
    When the SCTP association contains a single DATA/SACK chunk in direction
    the max and min TSN values are equal and as a result the Y axis range is
    (maxTSN, maxTSN) or (0, 0) and the dots for the TSN are not visible
    
    To fix this always set the Y axis maximum to maxTSN + 1 similar to the X
    axis maximum of max_secs + 1
    
    Also removed one unused local variable
    
    Change-Id: Id38eb4dbd13a8ebbba98d4df00f3707331bd1464
    Reviewed-on: https://code.wireshark.org/review/28862
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  02b2c86   SCTPGraphArwndDialog: Detect max arwnd value when startArwnd is not set
    adds  7e755f7   SCTPGraphDialog: fix displaying a single TSN


Summary of changes:
 ui/qt/sctp_graph_dialog.cpp | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)