Wireshark · Wireshark-commits: [Wireshark-commits] master 9ca8a9f: test: do not silently ignore feature detection failures

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9ca8a9f87c4e340f7e4d44c4c32dfc74afec29fa
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9ca8a9f by Peter Wu (peter@xxxxxxxxxxxxx):

    test: do not silently ignore feature detection failures
    
    When ASAN memleak detection is enabled, any memory leak would result in
    an exception and subsequently all features are marked as missing.
    With the default profile, any Lua plugin or certain configurations could
    cause a memory leak. To avoid such interference, set the configuration
    path to a dummy location and warn whenever an error happens nonetheless.
    
    Do not call setProgramPath() immediately, there is no "tshark" binary in
    the current working directory anymore. Rely on test.py to set the path.
    
    Change-Id: Idccc3d68eb6f6bb64d3a0b32897acecc65e0dfb6
    Reviewed-on: https://code.wireshark.org/review/28867
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  99242af   Revert "Pass all arguments to options as --option=argument."
    adds  9ca8a9f   test: do not silently ignore feature detection failures


Summary of changes:
 test/config.py | 38 +++++++++++++++++++-------------------
 1 file changed, 19 insertions(+), 19 deletions(-)