Wireshark · Wireshark-commits: [Wireshark-commits] master 8a0cbd4: Add a preference to override the radiotap FCS bit.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8a0cbd49ad03495670e5803cbad9d083779ba351
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8a0cbd4 by Guy Harris (guy@xxxxxxxxxxxx):

    Add a preference to override the radiotap FCS bit.
    
    This is separate from the 802.11 preference, which only affects packets
    where no file or packet metadata indicates whether there is an FCS (yes,
    that is intentional behavior).  This is specifically for radiotap, in
    case some driver fails to set the FCS bit correctly (this is currently
    an issue with Npcap, which currently assumes that the packet has an FCS
    iff NDIS indicated the packet with the DOT11_RECV_FLAG_RAW_PACKET flag;
    that doesn't appear to be a reliable indicator, and it's not clear there
    *is* a reliable indicator, so Npcap might have to fall back on something
    really gross like a quirks database for particular adapters).
    
    Change-Id: Ia3b134d89004307442d42cfa5ed3cf8fb938235f
    Ping-Bug: 15010
    Reviewed-on: https://code.wireshark.org/review/28855
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  98ecf04   GSM SIM: Show length for 0x9f status word
    adds  8a0cbd4   Add a preference to override the radiotap FCS bit.


Summary of changes:
 epan/dissectors/packet-ieee80211-radiotap.c | 36 ++++++++++++++++++++++++++---
 1 file changed, 33 insertions(+), 3 deletions(-)