Wireshark · Wireshark-commits: [Wireshark-commits] master 4a498ae: Don't remove a tap listener we didn't find in the first place.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a498ae7982a1234ab5584b02de93c99fb89f9fe
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4a498ae by Guy Harris (guy@xxxxxxxxxxxx):

    Don't remove a tap listener we didn't find in the first place.
    
    If remove_tap_listener() doesn't find a tap listener with the specified
    data, print a warning message and skip the "remove the tap listener"
    steps.
    
    This means that the internal free_tap_listener() won't be called with a
    null listener; remove the now-unnecessary check (if anybody *does* call
    it with a null pointer, that's a bug).
    
    This prevents the crash in bug 15006, but that now produces a warning
    message; it doesn't fix the underlying bug, it just changes the symptom.
    
    Change-Id: Ia9a2bfa3d57b86eac0d6e0b0bad03a7b81e254e3
    Ping-Bug: 15006
    Reviewed-on: https://code.wireshark.org/review/28853
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  3071af2   GSM SIM: Parse 0x61 and 0x6C status words
    adds  4a498ae   Don't remove a tap listener we didn't find in the first place.


Summary of changes:
 epan/tap.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)