Wireshark-commits: [Wireshark-commits] master 7618aa0: CIP Motion: Code cleanup
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 25 Jul 2018 07:00:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7618aa055c8eed4cd739d88019c3955ca84ef5fd
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7618aa0 by Dylan Ulis (daulis0@xxxxxxxxx):

    CIP Motion: Code cleanup
    
    1. Remove unused function parameters
    2. Some tvb_get --> ret_uint
    3. Move some variables to smaller scope. Better practice, and it's easier to see what variables need to persist outside of for loops.
    4. Combine some scattered if (dimension == 1) blocks.
    
    No functional changes.
    
    Change-Id: Ifb2affb968356fcd7e980fd4ee046cf359252df4
    Reviewed-on: https://code.wireshark.org/review/28845
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  461d9be   coap/oscore: fix conflict
    adds  7618aa0   CIP Motion: Code cleanup


Summary of changes:
 epan/dissectors/packet-cipmotion.c | 102 ++++++++++++++++---------------------
 1 file changed, 44 insertions(+), 58 deletions(-)