Wireshark-commits: [Wireshark-commits] master-2.6 aafca47: Do some more checks.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 22 Jul 2018 18:52:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=aafca47bd31d094107715262cb8a5e326f913f0a
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

aafca47 by Guy Harris (guy@xxxxxxxxxxxx):

    Do some more checks.
    
    Don't assume that the amount of data remaining in the packet is greater
    than or equal to the amount of padding; it might not be.  Throw an
    exception if it isn't.
    
    Make sure data eists before allocating a buffer for it and copying with
    tvb_memcpy(), in case the length is too big.
    
    Change-Id: Icde8b8cc687b7b9229756aabddb246f9b98c3a22
    Ping-Bug: 14999
    Reviewed-on: https://code.wireshark.org/review/28810
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit f99d2d2afe4b92a00f3789de572a4183f226fed1)
    Reviewed-on: https://code.wireshark.org/review/28811
    

Actions performed:

    from  10db757   Don't assume a given btgatt.uuid0xXXXX dissector exists.
    adds  aafca47   Do some more checks.


Summary of changes:
 epan/dissectors/packet-http2.c | 27 +++++++++++++++++++++++----
 1 file changed, 23 insertions(+), 4 deletions(-)