Wireshark-commits: [Wireshark-commits] master 9e20822: CIP Motion: Attribute updates
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 21 Jul 2018 19:24:52 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9e20822ae27230cddbbcddb563fb04dc852d5f09
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9e20822 by Dylan Ulis (daulis0@xxxxxxxxx):

    CIP Motion: Attribute updates
    
    1. Add more attribute definitions
    2. Remove data that was only in object revision 1. This conflicts with
       the newer object definitions. No actual devices implemented this
       version.
    3. Correct data from enum --> bit fields
    4. Extract Methods into functions that are shared by attributes
       and other parsing.
    
    Change-Id: I5a08188466349b7d735346981b16e096ae68032d
    Reviewed-on: https://code.wireshark.org/review/28776
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ac1cb82   add MsgPack dissector.
    adds  9e20822   CIP Motion: Attribute updates


Summary of changes:
 epan/dissectors/packet-cipmotion.c | 298 +++++++++++--------------------------
 epan/dissectors/packet-cipmotion.h |   2 +-
 2 files changed, 90 insertions(+), 210 deletions(-)