Wireshark-commits: [Wireshark-commits] master b622b1f: Clean up tests.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 20 Jul 2018 21:57:14 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b622b1f5c1804c379327590a7afad00852de822c
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b622b1f by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up tests.
    
    On Windows with MSVC, just assume we have 64-bit file offset support,
    including _fseeki64() and _ftelli64().
    
    On UN*X, test for Large File Support and for fseeko()/ftello(), and for
    what #defines are needed to enable them.
    
    On Windows without MSVC, test for Large File Support, but assume we have
    _fseeki64() and _ftelli64(); what *should* we be doing?
    
    Clean up indentation and else()/endif() arguments while we're at it.
    
    Change-Id: I801d1f4059abbed2d5123d2375a560634a9ee056
    Reviewed-on: https://code.wireshark.org/review/28781
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  977f4c2   CMake: Don't bother testing for _fseeki64 on Windows.
    adds  b622b1f   Clean up tests.


Summary of changes:
 cmake/modules/gmxTestLargeFiles.cmake | 193 ++++++++++++++++++----------------
 1 file changed, 102 insertions(+), 91 deletions(-)