Wireshark-commits: [Wireshark-commits] master 61dd06e: Lua: Switch from disable_lua to enable_lua.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 20 Jul 2018 06:42:48 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=61dd06ed9f56a15adaf8b4f141d2f7e47670196b
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

61dd06e by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Lua: Switch from disable_lua to enable_lua.
    
    Deprecate "disable_lua" in favor of "enable_lua". Configuration options
    typically use "true" or a similar value to enable features. Using
    "disable_lua = false" to enable Lua seems odd.
    
    Change-Id: I224acad0559d409ea0a28b5555d1eb898564328c
    Reviewed-on: https://code.wireshark.org/review/28773
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  381ea09   WSUG: Update the Statistics chapter to match current Qt UI
    adds  61dd06e   Lua: Switch from disable_lua to enable_lua.


Summary of changes:
 docbook/wsluarm.asciidoc     | 24 +++++++++++++-----------
 epan/wslua/init_wslua.c      | 16 +++++++++++++---
 epan/wslua/template-init.lua |  6 +++---
 test/lua/globals_2.2.txt     |  2 +-
 tools/pre-commit-ignore.conf |  1 +
 5 files changed, 31 insertions(+), 18 deletions(-)