Wireshark-commits: [Wireshark-commits] master-2.6 1ef4bbe: Qt: update to QCustomPlot 1.3.2
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 18 Jul 2018 15:06:24 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1ef4bbed55c690848432cd8c6fe48b8250099130
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

1ef4bbe by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: update to QCustomPlot 1.3.2
    
    QCustomPlot 1.3.1 includes a fix for a crash ("Fixed potential crash in
    QCPGraph::pointDistance if getScatterPlotData returns empty list").
    Full changelog: http://www.qcustomplot.com/release/1.3.2/changelog.txt
    
    The new files are based on QCustomPlot-source.tar.gz (1.3.2) with
    Alexis' typo and license header changes from v1.99.2rc0-479-gc411029a3c
    ("Update to QCustomPlot 1.3.0") applied. All successive Wireshark
    patches up to v2.5.0rc0-854-g6f28f1a59e ("Fix MacOS build") were
    applied. The Retina patches ("Fix QCustmPlot retina problems." and "QCP:
    Fix retina label calculations.") gave conflicts due contextual changes
    which I resolved by renaming newCachedLabel to cachedLabel (following
    the change in upstream commit baaad24706187f5be0a68011c780b51c4de11558).
    
    Bug: 14971
    Change-Id: I5012cb5a867891b466cbf1898fe4c28cbd11ba20
    Reviewed-on: https://code.wireshark.org/review/28732
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 8563b94d567c7ab8dfbaef7e72623e413a573ab9)
    Reviewed-on: https://code.wireshark.org/review/28739
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  76a728e   checkAPIs.pl: fix false positive with C++ method names
    adds  1ef4bbe   Qt: update to QCustomPlot 1.3.2


Summary of changes:
 ui/qt/widgets/qcustomplot.cpp | 929 +++++++++++++++++++++++-------------------
 ui/qt/widgets/qcustomplot.h   |  11 +-
 2 files changed, 518 insertions(+), 422 deletions(-)