Wireshark · Wireshark-commits: [Wireshark-commits] master 118017e: Supply a 0s/0ns value for invalid time value lengths.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=118017e3e2e0b3a9b8ec4ac83645d3289a2e06f7
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

118017e by Guy Harris (guy@xxxxxxxxxxxx):

    Supply a 0s/0ns value for invalid time value lengths.
    
    Other routines that fetch values and can report a type/length error
    without throwing an exception return a value, even if it's not the
    appropriate value (as there is no appropriate value); make
    get_time_value() do the same.
    
    Ideally, we'd mark the protocol tree item, and the value, as being
    invalid, and treat invalid values specially, but that's a bigger change
    that would involve significantly more mucking about in the innards of
    epan/proto.c as well as in code that looks at the protocol tree and at
    field values, as well as deciding what the appropriate thing to do is
    with a field with no value when, for example, -T {fields,pdml,json,ek,etc.}
    is used.
    
    Bug: 14957
    Change-Id: Iab91198e560f52809d989cfce8b51b1b027cff73
    Reviewed-on: https://code.wireshark.org/review/28722
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  1686032   Update the comment giving I-D URLs.
    adds  118017e   Supply a 0s/0ns value for invalid time value lengths.


Summary of changes:
 epan/proto.c | 85 ++++++++++++++++++++++++++++++++++++++++++++++++------------
 1 file changed, 68 insertions(+), 17 deletions(-)