Wireshark-commits: [Wireshark-commits] master-2.6 9012ff0: The maximum offset in an IP option disse
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 14 Jul 2018 21:44:54 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9012ff05fc918291739f2cb75368d6f8b969264c
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

9012ff0 by Guy Harris (guy@xxxxxxxxxxxx):

    The maximum offset in an IP option dissector is the length of the option.
    
    It's *not* the sum of the length of the option and the length of the
    option header.
    
    Change-Id: I0b5ab0e35ca33dc02a0bc2501e0f0f531ec3f376
    Reviewed-on: https://code.wireshark.org/review/28701
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 1834cda2ee945c09f3306e001af9d9bac97d6422)
    Reviewed-on: https://code.wireshark.org/review/28702
    

Actions performed:

    from  3bdaf7b   Qt: try to sort numeric columns (such as ports) as number
    adds  9012ff0   The maximum offset in an IP option dissector is the length of the option.


Summary of changes:
 epan/dissectors/packet-ip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)