Wireshark · Wireshark-commits: [Wireshark-commits] master dac91db: mptcp: Correctly find mappings and reinjections

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dac91db65e756a3198616da8cca11d66a5db6db7
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

dac91db by Matthieu Coudron (mattator@xxxxxxxxx):

    mptcp: Correctly find mappings and reinjections
    
    - removed mptcp.duplicated_dsn in favor of mptcp.reinjection_of/mptcp.reinjected_in
    reinjected_in lists the packets where the DSN was later reinjected in.
    reinjection_of lists the packets in which this DSN was already transmitted.
    - There was a bug where the max_edge property of the interval tree was not
    correctly updated. Right now wireshark gives a dsn for every TCP frame (even
    empty packets).
    - Now displays mappings only for packets with data (seglen > 0).
    - Renamed dsn_map to dsn2packet_map and mappings to ssn2dsn_mappings.
    - precises the complexity of enabling certain MPTCP options so that the user
    better understand their impact on processing speed.
    
    Change-Id: I24adc3161021b7f6a084763a74dc580f1c1f2c2e
    Reviewed-on: https://code.wireshark.org/review/28326
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c5ede2f   gprscdr: Update to 3GPP TS 32.298 V15.3.0
    adds  dac91db   mptcp: Correctly find mappings and reinjections


Summary of changes:
 epan/dissectors/packet-tcp.c   | 145 ++++++++++++++++++++++-------------------
 epan/dissectors/packet-tcp.h   |  15 +++--
 epan/wmem/wmem_interval_tree.c |   2 +-
 3 files changed, 88 insertions(+), 74 deletions(-)