Wireshark-commits: [Wireshark-commits] master 1695369: Qt: make "Save As" in Follow Streams usable
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 11 Jul 2018 16:30:48 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=16953695d734555a4472bada9d2dec799544d619
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1695369 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: make "Save As" in Follow Streams usable
    
    For formats other than "Raw" and "UTF-8", the written file does not
    match the actual stream data. It would be duplicated in strange ways.
    Executing the "Save As" action twice while the dialog is open would also
    write two different files (huh?).
    
    As a quick fix, just replace the strange save logic by writing the text
    field contents. A functional difference is that previously it would
    write data while parsing the "follow data" list, now it uses the text
    field contents. That data will now be truncated after 500 MB.
    
    Bug: 14933
    Change-Id: I498676389d0da3ac070346d6903bd2e6b0fc7674
    Fixes: v1.11.0-rc1-2538-g80f9326b2f ("Add TCP/UDP/SSL Follow feature to QtShark")
    Reviewed-on: https://code.wireshark.org/review/28663
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  ec22bcc   DeviceNet: Add reference to spec name
    adds  1695369   Qt: make "Save As" in Follow Streams usable


Summary of changes:
 ui/qt/follow_stream_dialog.cpp | 72 +++++++++++++-----------------------------
 ui/qt/follow_stream_dialog.h   |  2 --
 2 files changed, 22 insertions(+), 52 deletions(-)