Wireshark-commits: [Wireshark-commits] master 5a560f3: dns: fix off-by-one buffer overflow (write)
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 08 Jul 2018 21:24:00 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5a560f3f6aa2cbfad957cf6223e50c3b61ef575b
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5a560f3 by Peter Wu (peter@xxxxxxxxxxxxx):

    dns: fix off-by-one buffer overflow (write)
    
    "maxname" is the size of the buffer which also includes the "null
    label" (represented by the NUL byte). Do not write this past the end.
    
    Bug: 14955
    Change-Id: I51e2237741807aded7ffb82c178d7d7ce5123f78
    Fixes: v2.9.0rc0-1142-g53e04b621c ("DNS: fix in expand_dns_name")
    Reviewed-on: https://code.wireshark.org/review/28657
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Erika Szelleová <szelleerika@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  6f665e3   H.265: implement Level bit rates, few general fixes.
    adds  5a560f3   dns: fix off-by-one buffer overflow (write)


Summary of changes:
 epan/dissectors/packet-dns.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)