Wireshark-commits: [Wireshark-commits] master 55c6038: xnap: fix use-after-free of "xnap_conv->addr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 08 Jul 2018 15:24:54 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=55c6038fb03ce0594b2042200f1d6ec66187849e
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

55c6038 by Peter Wu (peter@xxxxxxxxxxxxx):

    xnap: fix use-after-free of "xnap_conv->addr_a"
    
    Fix wrong memory scope to address a heap-use-after-free via:
    
        addresses_equal epan/address.h:218:10
        dissect_xnap_T_rrc_Context_01 epan/dissectors/asn1/xnap/xnap.cnf:127
    
    Change-Id: I38bb64c2c8809cb1224d2c44076255d1789c4d5e
    Fixes: v2.9.0rc0-1116-gcc5701fbb1 ("XnAP: add dissector based on v15.0.0")
    Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9199
    Reviewed-on: https://code.wireshark.org/review/28658
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  0e04369   [Automatic update for 2018-07-08]
    adds  55c6038   xnap: fix use-after-free of "xnap_conv->addr_a"


Summary of changes:
 epan/dissectors/asn1/xnap/packet-xnap-template.c | 4 ++--
 epan/dissectors/packet-xnap.c                    | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)