Wireshark-commits: [Wireshark-commits] master-2.6 6fc9501: tcp: fix Follow TCP Stream with missing
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 08 Jul 2018 11:51:05 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6fc9501956569fa6507498a0607c08885c39df59
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

6fc9501 by Peter Wu (peter@xxxxxxxxxxxxx):

    tcp: fix Follow TCP Stream with missing (but ACKed) segments
    
    Restore the direction for the first check_follow_fragments call to match
    the situation before commit 57acc227f0 (which broke other things, so its
    logic was reimplemented in commit v2.3.0rc0-1449-g66fa31415f ("tcp: Fix
    Follow TCP tap data and when its tapped.")).
    
    Ensure that the ACK value is checked before processing the sequence
    number and payload for the current flow.
    
    Bug: 14944
    Change-Id: If8947d7732683a4943f405eb72b1a8526a35a6dc
    Fixes: v2.1.0rc0-1339-g57acc227f0 ("KISS the Follow TCP functionality.")
    Reviewed-on: https://code.wireshark.org/review/28612
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 079d1521c6a24e39d283e3ce4e27d7c399e8e068)
    Reviewed-on: https://code.wireshark.org/review/28644
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  f3b2462   tcp: remove repetitive "follow_record->is_server"
    adds  6fc9501   tcp: fix Follow TCP Stream with missing (but ACKed) segments


Summary of changes:
 epan/dissectors/packet-tcp.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)