Wireshark-commits: [Wireshark-commits] master-2.6 4080e95: Distinguish between "reserved for implem
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 04 Jul 2018 22:52:43 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4080e95d921275641dd80adee4f53c8b81a31ea3
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

4080e95 by Guy Harris (guy@xxxxxxxxxxxx):

    Distinguish between "reserved for implementation" and "reserved for future use".
    
    Some flags in the connectionless PDU header are "reserved for
    implementation", which presumably means an implementation can set them
    to 0 or 1 and use it to send information to a compatible implementation;
    others are "reserved for future use" and "must be set to 0".
    
    Don't test the "reserved for implementation" flags in the heuristic, and
    show them as "Reserved for implementation" and show the others as
    "Reserved for future use (MBZ)".
    
    Bug: 14942
    Change-Id: Iff40f155e057301096fec1dbb68f71d041508ff1
    Reviewed-on: https://code.wireshark.org/review/28598
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 9e480c51bb64bf002a1cd28e9291b05b80049936)
    Reviewed-on: https://code.wireshark.org/review/28599
    

Actions performed:

    from  6ced31d   CaptureFile.fileTitle() is for display, not for file name processing.
    adds  4080e95   Distinguish between "reserved for implementation" and "reserved for future use".


Summary of changes:
 epan/dissectors/packet-dcerpc.c | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)