Wireshark · Wireshark-commits: [Wireshark-commits] master 536e26c: Qt: fix crash on opening a capture file while loading/saving ano

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=536e26c55ecd89825855b14b7edd9899dfe6a78c
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

536e26c by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix crash on opening a capture file while loading/saving another
    
    Closing a capture file while it is being loaded will result in a crash.
    As a workaround, disallow closing the capture file. The requested action
    (e.g. MainWindow::openCaptureFile) will be silently ignored.
    
    While at it, protect process_specified_records (called when saving
    files) similarly to cf_read and fix a crash that occurs when a capture
    from the Capture Dialog is started while a file is being loaded:
    
        file.c:360:cf_close: assertion failed: (cf->state != FILE_READ_IN_PROGRESS)
    
    Bug: 10870 # moving rapidly between large files in a file set
    Bug: 13594 # start capture while loading/saving file
    Bug: 14351 # open another file while loading file
    Change-Id: I6ce8f3163c3fa4869f0299e49909a32594326ce4
    Reviewed-on: https://code.wireshark.org/review/28541
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8a1e517   file: fix packet list update after dfilter change during live capture
    adds  536e26c   Qt: fix crash on opening a capture file while loading/saving another


Summary of changes:
 file.c                      |  9 +++++++++
 ui/qt/main_window.cpp       | 12 ++++++++++++
 ui/qt/main_window_slots.cpp | 18 ++++++++++++++----
 3 files changed, 35 insertions(+), 4 deletions(-)