Wireshark-commits: [Wireshark-commits] master-2.6 5005abc: Fix debugging code.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 01 Jul 2018 02:28:22 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5005abc360fc9114e2b08bc9b0ac4c2b589ad4f6
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

5005abc by Guy Harris (guy@xxxxxxxxxxxx):

    Fix debugging code.
    
    Don't show address or ports that aren't provided; this is especially
    important for address 1, where its absence is indicated by the pointer
    being null, so we can't blithely dereference it.
    
    Show ports as unsigned, because that's what they are.
    
    Change-Id: I162b6f08a3973c0cded0742c267a016dbb5ee31a
    Reviewed-on: https://code.wireshark.org/review/28543
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 747793afaea8a8abbb84012880173fd6a7b8434f)
    Reviewed-on: https://code.wireshark.org/review/28544
    

Actions performed:

    from  ce62875   file: do not perform recursive redissections to avoid crashes
    adds  5005abc   Fix debugging code.


Summary of changes:
 epan/conversation.c | 90 +++++++++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 87 insertions(+), 3 deletions(-)