Wireshark · Wireshark-commits: [Wireshark-commits] master 471fb9a: packet-dcm.c: heuristic dissection rework

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=471fb9a54ab7887b690b8b04d6ce2444098a3cbc
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

471fb9a by David Aggeler (david_aggeler@xxxxxxxxxx):

    packet-dcm.c: heuristic dissection rework
    
    - Fixed initial COL_INFO for associations. It used to 'append' instead of 'set'.
    - Changed initial length check from tvb_reported_length() to tvb_captured_length()
    - Heuristic Dissection:
      o Modified registration, so it can be clearly identified in the Enable/Disable Protocols dialog
      o Enabled by default
      o Return proper data type
    
    Tested heuristic vs. static on many DICOM captures
    
    Change-Id: I0aa42b91e4f55a6d9fc834657710a6a92c8dadef
    Reviewed-on: https://code.wireshark.org/review/27518
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  328f5cf   Q931: do not tap packet if no packet info is present
    adds  471fb9a   packet-dcm.c: heuristic dissection rework


Summary of changes:
 epan/dissectors/packet-dcm.c | 185 +++++++++++++++++++++++++++++--------------
 1 file changed, 126 insertions(+), 59 deletions(-)