Wireshark-commits: [Wireshark-commits] master 74d0be8: Disable coloring rules with invalid packet-t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 26 Jun 2018 03:25:03 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=74d0be82017513e99cc0ecdc994e3c1c99fc74f7
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

74d0be8 by Guy Harris (guy@xxxxxxxxxxxx):

    Disable coloring rules with invalid packet-testing expressions.
    
    If the packet-testing expression for a coloring rule is set to an
    invalid expression, disable the filter; this should provide at least
    *some* indication to the user that it's not valid, although we should
    really pop up a dialog or something - the little small-type notice below
    the list of filters is *really* not all that obvious.
    
    Ping-Bug: 14906
    Change-Id: I3c036c3509520913db0a64c30bc1c57c0c7667bc
    Reviewed-on: https://code.wireshark.org/review/28444
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  168ddd4   Try to fix the macOS builder.
    adds  74d0be8   Disable coloring rules with invalid packet-testing expressions.


Summary of changes:
 ui/qt/models/coloring_rules_delegate.cpp | 1 +
 1 file changed, 1 insertion(+)