Wireshark-commits: [Wireshark-commits] master 3a514ca: Qt: Move FilterToolBar to a separate class
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 25 Jun 2018 22:22:58 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3a514caaf1e3b36eb284c3a566d489aba6df5392
Submitter: Roland Knall (rknall@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3a514ca by Roland Knall (rknall@xxxxxxxxx):

    Qt: Move FilterToolBar to a separate class
    
    Remove all filter toolbar related stuff into a separate class
    and away from MainWindow
    
    Change-Id: I36d937be6c2686b16a8d494213dc740d8d28efcb
    Reviewed-on: https://code.wireshark.org/review/28432
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  5404cbb   drb/rbm: fix indentation issues.
    adds  3a514ca   Qt: Move FilterToolBar to a separate class


Summary of changes:
 ui/qt/CMakeLists.txt                        |   2 +
 ui/qt/main_window.cpp                       |  35 +---
 ui/qt/main_window.h                         |  21 +-
 ui/qt/main_window_slots.cpp                 | 248 ++---------------------
 ui/qt/widgets/filter_expression_toolbar.cpp | 303 ++++++++++++++++++++++++++++
 ui/qt/widgets/filter_expression_toolbar.h   |  62 ++++++
 6 files changed, 393 insertions(+), 278 deletions(-)
 create mode 100644 ui/qt/widgets/filter_expression_toolbar.cpp
 create mode 100644 ui/qt/widgets/filter_expression_toolbar.h