Wireshark-commits: [Wireshark-commits] master f56b504: Don't pass an un-initialized dummy structure
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 23 Jun 2018 23:10:43 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f56b50406704a77e1816802a10863f06652fa404
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f56b504 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't pass an un-initialized dummy structure to dissect_cip_io_generic().
    
    If we know the information that belongs there, we should fill it in.
    Otherwise, we should just pass a null pointer, meaning "we don't know
    what this information is", and we should check for the null pointer and
    not check the information in question.
    
    Bug: 14894
    Change-Id: I4f5249855330db65242d8b6eb6b5bda3af3a1925
    Reviewed-on: https://code.wireshark.org/review/28404
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  9f8c332   RTP: code cleanup 3
    adds  f56b504   Don't pass an un-initialized dummy structure to dissect_cip_io_generic().


Summary of changes:
 epan/dissectors/packet-enip.c | 30 ++++++++++++++----------------
 1 file changed, 14 insertions(+), 16 deletions(-)