Wireshark-commits: [Wireshark-commits] master 013675c: DHCPv4: Fix dissection of packets using HMAC
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 21 Jun 2018 13:30:25 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=013675c9adf58050757bc534a5f126246390afea
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

013675c by Dhiru Kholia (dhiru.kholia@xxxxxxxxx):

    DHCPv4: Fix dissection of packets using HMAC-MD5 authentication
    
    See https://tools.ietf.org/html/rfc3118#section-5.2 (Authentication for
    DHCP Messages) for more details.
    
    Sample DHCPv4 authentication .pcap file can be found at,
    https://wiki.wireshark.org/SampleCaptures
    
    Without this patch, Wireshark shows "Expert Info (Error/Protocol):
    length isn't >= 31" error message in the Authentication section of the
    packet dissection.
    
    Change-Id: I2af5c7d18f0497a131b1d2dc50ee6e4708c34e28
    Signed-off-by: Dhiru Kholia <dhiru.kholia@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/28360
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  9190cd1   Add dissector for Exablaze timestamping trailers
    adds  013675c   DHCPv4: Fix dissection of packets using HMAC-MD5 authentication


Summary of changes:
 epan/dissectors/packet-bootp.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)