Wireshark-commits: [Wireshark-commits] master 31c1cd9: DNS: changed maximum length of dns names fro
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 19 Jun 2018 08:40:59 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=31c1cd95cfce27a12f364eb3de78efd2b0c6d1b8
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

31c1cd9 by Erika Szelleova (szelleerika@xxxxxxxxx):

    DNS: changed maximum length of dns names from 1025 to 255
    
    According to RFC1035 there are limitations on the maximum length of DNS
    names. The maximum length in the code was defined as 1025, this commit
    changes it to 255. Also a new macro is introduced which holds the
    minimum length of a DNS name.
    
    Bug: 14041
    Change-Id: Ic63b332b2a357e33728df183c05ab0e222faf13f
    Reviewed-on: https://code.wireshark.org/review/28309
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  bf82900   PDCP NR: fix IP tvbuff creation when MAC-I is present
    adds  31c1cd9   DNS: changed maximum length of dns names from 1025 to 255


Summary of changes:
 epan/dissectors/packet-dns.c | 11 ++++++-----
 epan/dissectors/packet-dns.h |  2 +-
 epan/dissectors/packet-nbt.c |  2 +-
 3 files changed, 8 insertions(+), 7 deletions(-)