Wireshark-commits: [Wireshark-commits] master-2.6 610a74b: For the contains operator, both sides ha
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 17 Jun 2018 22:03:14 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=610a74b1789636403a9baf56770fb25590758149
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

610a74b by Guy Harris (guy@xxxxxxxxxxxx):

    For the contains operator, both sides have to have the same type.
    
    Have charconst_to_bytes() take the desired type as an argument, and pass
    it to dfilter_fvalue_from_unparsed().
    
    Bug: 14084
    Change-Id: I11db417311b9681b18c4a3fca2862b35837194d7
    Reviewed-on: https://code.wireshark.org/review/28315
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 078a53f9942e4092d4d18344fa758ab47be39335)
    Reviewed-on: https://code.wireshark.org/review/28316
    

Actions performed:

    from  d92a7a6   character constant in dfilter now must fit into one byte
    adds  610a74b   For the contains operator, both sides have to have the same type.


Summary of changes:
 epan/dfilter/semcheck.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)