Wireshark-commits: [Wireshark-commits] master 580b2e1: GSUP: fix incorrect message types
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 16 Jun 2018 11:07:20 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=580b2e13f104a4890451664f9018ca60902300fb
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

580b2e1 by Vadim Yanitskiy (axilirator@xxxxxxxxx):

    GSUP: fix incorrect message types
    
    In the reference libosmocore's implementation we have:
    
      OSMO_GSUP_MSGT_PURGE_MS_REQUEST	= 0b00001100, // 0x0c
      OSMO_GSUP_MSGT_PURGE_MS_ERROR		= 0b00001101, // 0x0d
      OSMO_GSUP_MSGT_PURGE_MS_RESULT	= 0b00001110, // 0x0e
    
    while here we had:
    
      OSMO_GSUP_MSGT_PURGE_MS_REQUEST	= 0x0c,
      OSMO_GSUP_MSGT_PURGE_MS_ERROR		= 0x0e, // != 0x0d
      OSMO_GSUP_MSGT_PURGE_MS_RESULT	= 0x0f, // != 0x0e
    
    Same problem with the 'OSMO_GSUP_MSGT_LOCATION_CANCEL_RESULT'.
    
    Change-Id: Ie49fd2fca8298d97c21e03649935704309015324
    Reviewed-on: https://code.wireshark.org/review/28297
    Reviewed-by: Harald Welte <laforge@xxxxxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  1a8ed6f   Fix NFSv4.2 CHANGE_TYPE constants
    adds  580b2e1   GSUP: fix incorrect message types


Summary of changes:
 epan/dissectors/packet-gsm_gsup.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)