Wireshark · Wireshark-commits: [Wireshark-commits] master 94bf85a: ENIP: Pull out CPF items to separate functions

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=94bf85ad26b6c244e49067921dbadcf2db4fd9cb
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

94bf85a by Dylan Ulis (daulis0@xxxxxxxxx):

    ENIP: Pull out CPF items to separate functions
    
    dissect_cpf was huge and too hard to read and update.
    This change pulls out item parsing into individual functions to make
    it easier to read, help troubleshoot a bug related to ENIP TLS
    connection filtering (Still investigating), and prep for future features.
    
    There are no functional changes.
    
    Main changes:
    1. Pulled out the following code into separate functions:
        dissect_item_list_identity
        dissect_item_cip_security_information
        dissect_item_list_services_response
        dissect_item_sockaddr_info
        dissect_item_sequenced_address
        dissect_item_connected_address
        dissect_item_unconnected_message_over_udp
        dissect_generic_io
        dissect_cip_class01_io
    2. More documentation. It was a little hard to follow before.
    3. Corrected offset inside the while loop in dissect_cpf(). Previously,
    offset pointed to 2 bytes *before* the item actually being processed.
    
    Change-Id: I47894fd5c50b4c3d07f916f81e1b21f8890c8396
    Reviewed-on: https://code.wireshark.org/review/28205
    Reviewed-by: Dylan Ulis <daulis0@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  4059b56   DOCSIS: correct reassembly of UCD in REG-RSP-MP and DBC-REQ messages
    adds  94bf85a   ENIP: Pull out CPF items to separate functions


Summary of changes:
 epan/dissectors/packet-enip.c | 690 +++++++++++++++++++++++-------------------
 1 file changed, 381 insertions(+), 309 deletions(-)