Wireshark-commits: [Wireshark-commits] master-2.4 cce6ebd: Don't let randpkt write packets libwiret
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 12 Jun 2018 18:25:38 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cce6ebdf323917720163b8c7d54e5455ab66a5f7
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

cce6ebd by Guy Harris (guy@xxxxxxxxxxxx):

    Don't let randpkt write packets libwiretap can't read.
    
    Wiretap imposes an arbitrary limit on the maximum packet size, to
    prevent it from trying to allocate a huge packet buffer and possibly
    running out of address space on ILP32 platforms or just eating too much
    backing store on LP64/LLP64 platforms.  Don't write packets with a
    length greater than that limit.
    
    Bug: 14107
    Change-Id: Iba4fe3b008b044215647ba3f838ae7b3ac66c585
    Reviewed-on: https://code.wireshark.org/review/28232
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 4e7f4881d2cf6fe69de0661c2441e82dd525e59e)
    Reviewed-on: https://code.wireshark.org/review/28234
    

Actions performed:

    from  8d626dc   Clean up handling of counted blobs of bytes.
    adds  cce6ebd   Don't let randpkt write packets libwiretap can't read.


Summary of changes:
 randpkt_core/randpkt_core.c | 7 +++++++
 1 file changed, 7 insertions(+)