Wireshark-commits: [Wireshark-commits] master-2.2 6c44312: Clean up handling of counted blobs of by
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6c44312f465014eb409d766a9828b7f101f6251c
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark
Commits:
6c44312 by Guy Harris (guy@xxxxxxxxxxxx):
Clean up handling of counted blobs of bytes.
Don't treat the count+blob as itself a blob of bytes; use FT_NONE.
Create it with an unknown length (-1, meaning "to end of packet, for
now"), and set its length once we've finished dissecting it. Dissect
the raw bytes of a prefixed-bytes item regardless of whether we're
building a protocol tree or not.
This means we do a better job of handling a too-large length; instead of
overflowing the offset, we throw an exception and stop dissecting, so we
don't run the risk of looping infinitely.
Bug: 14841
Change-Id: I593be9b6ba9aa15d8529f96458e53b85ace6402a
Reviewed-on: https://code.wireshark.org/review/28228
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
(cherry picked from commit a03eacc7aabd04a6fd0db978e0d7597220ac0515)
Reviewed-on: https://code.wireshark.org/review/28231
Actions performed:
from 203b37f [Automatic update for 2018-06-10]
adds 6c44312 Clean up handling of counted blobs of bytes.
Summary of changes:
epan/dissectors/packet-bzr.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)