Wireshark-commits: [Wireshark-commits] master a03eacc: Clean up handling of counted blobs of bytes.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 12 Jun 2018 17:50:15 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a03eacc7aabd04a6fd0db978e0d7597220ac0515
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a03eacc by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up handling of counted blobs of bytes.
    
    Don't treat the count+blob as itself a blob of bytes; use FT_NONE.
    Create it with an unknown length (-1, meaning "to end of packet, for
    now"), and set its length once we've finished dissecting it.  Dissect
    the raw bytes of a prefixed-bytes item regardless of whether we're
    building a protocol tree or not.
    
    This means we do a better job of handling a too-large length; instead of
    overflowing the offset, we throw an exception and stop dissecting, so we
    don't run the risk of looping infinitely.
    
    Bug: 14841
    Change-Id: I593be9b6ba9aa15d8529f96458e53b85ace6402a
    Reviewed-on: https://code.wireshark.org/review/28228
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  362576e   gtpv2: Avoid possible misuse of comma operator warning
    adds  a03eacc   Clean up handling of counted blobs of bytes.


Summary of changes:
 epan/dissectors/packet-bzr.c | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)