Wireshark-commits: [Wireshark-commits] master-2.6 4bd70c4: If device->active_dlt = -1, show "Unknow
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 10 Jun 2018 02:43:41 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4bd70c411ee28eda55b74aba70e29e1ae9916fcd
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

4bd70c4 by Guy Harris (guy@xxxxxxxxxxxx):

    If device->active_dlt = -1, show "Unknown" rather than "DLT -1".
    
    It means we don't know the active link-layer header type - probably
    because the device can't be opened, so we can't get the default linktype
    or the list of available linktypes - so show it as "Unknown".
    
    Bug: 14847
    Change-Id: I5a1ad360d2ae461e8db57e387679700a566b0949
    Reviewed-on: https://code.wireshark.org/review/28185
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 3c9c2c65341bae5a7b983af2a572b8a9a99b543c)
    Reviewed-on: https://code.wireshark.org/review/28186
    

Actions performed:

    from  9aa3dc7   Do bounds checking of the offset and length in proto_tree_add_string().
    adds  4bd70c4   If device->active_dlt = -1, show "Unknown" rather than "DLT -1".


Summary of changes:
 ui/qt/capture_interfaces_dialog.cpp   | 20 +++++++++++++-------
 ui/qt/models/interface_tree_model.cpp | 20 ++++++++++++++------
 2 files changed, 27 insertions(+), 13 deletions(-)