Wireshark-commits: [Wireshark-commits] master 7ae1c68: s101: add initializer.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 08 Jun 2018 07:08:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7ae1c683f3024d0aea292cf6b853ebb79e71b06c
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7ae1c68 by Dario Lombardo (lomato@xxxxxxxxx):

    s101: add initializer.
    
    ../epan/dissectors/packet-s101.c: In function ‘dissect_S101’:
    ../epan/dissectors/packet-s101.c:279:53: error: ‘app_bytes_len’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
              ((*flags & 0xF) || (S101_DTD_GLOW != *dtd) || (APP_BYTES_LEN != app_bytes_len)))) {
                                                         ^
    ../epan/dissectors/packet-s101.c:241:12: note: ‘app_bytes_len’ was declared here
         guint8 app_bytes_len;
                ^
    cc1: all warnings being treated as errors
    
    Change-Id: Ibc7ab9206aeda2afe895a1813e7d4cb196b41817
    Reviewed-on: https://code.wireshark.org/review/28105
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  1c7b101   New protocol support for Lawo EmberPlus which is Glow embedded in S101
    adds  7ae1c68   s101: add initializer.


Summary of changes:
 epan/dissectors/packet-s101.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)